[engine] Remove excess subject from literal selector #4293

Merged
merged 1 commit into from Feb 28, 2017

Conversation

Projects
None yet
2 participants
@stuhood
Member

stuhood commented Feb 28, 2017

Problem

SelectLiteral doesn't care about the requester's subject: it carries its own output value along with it. But currently we're creating a new instance of the SelectLiteral per caller.

Solution

Drop the excess subject value from SelectLiteral to avoid creating one per unique requesting subject.

@stuhood stuhood requested a review from baroquebobcat Feb 28, 2017

@baroquebobcat

Looks good! I like short reviews.

@stuhood stuhood merged commit 66fcfb8 into pantsbuild:master Feb 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/remove-excess-subject-from-literal branch Feb 28, 2017

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

SelectLiteral isn't tied to the requester's subject: it has its own. (#…
…4293)

### Problem

`SelectLiteral` doesn't care about the requester's subject: it carries its own output value along with it. But currently we're creating a new instance of the `SelectLiteral` per caller.

### Solution

Drop the excess subject value from `SelectLiteral` to avoid creating one per unique requesting subject.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment