A setup_py task for the new python pipeline. #4308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjyw
force-pushed
the
new_pipeline_setup_py
branch
from
2ebfc82
to
3b073a3
Compare
Copied from the old one, with the previous special-casing of codegen removed (since codegen targets are just producers of source code products now, the new python tasks don't invoke codegen directly like the old ones do). However this task does still require some special handling of codegen - when selecting the targets to operate on we have to replace any codegen target roots with their corresponding synthetic targets. This change also copies the old task's unit tests, except the ones pertaining to codegen, which would no longer work without setting up and running codegen tasks. Instead, this change adds a regression test that ensures that we create an appropriate sdist from codegen targets, thus exercising the special handling mentioned above.
benjyw
force-pushed
the
new_pipeline_setup_py
branch
from
3b073a3
to
fb3eb89
Compare
kwlzn
approved these changes
Mar 6, 2017
| from pants_test.pants_run_integration_test import PantsRunIntegrationTest | ||
|
|
||
|
|
||
| class PythonReplIntegrationTest(PantsRunIntegrationTest): |
There was a problem hiding this comment.
D'oh! Sucking at copypasta is a rare achievement indeed... :)
lenucksi
pushed a commit
to lenucksi/pants
that referenced
this pull request
Apr 25, 2017
Copied from the old one, with the previous special-casing of codegen removed (the new python tasks don't invoke codegen directly like the old ones did). However this task does still require some special handling of codegen: when selecting the targets to operate on we have to replace any codegen target roots with their corresponding synthetic targets, as those are the ones with the actual sources to publish. This change also copies the old task's unit tests, except the ones pertaining to codegen (which would no longer work without setting up and running codegen tasks in the tests). Instead, this change adds an integration test that ensures that we create an appropriate sdist from codegen targets, thus exercising the special handling mentioned above (and incidentally also verifying that our new pipeline does do the right thing regarding synthesizing library targets for generated code).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from the old one, with the previous special-casing of
codegen removed (the new python tasks don't invoke
codegen directly like the old ones did).
However this task does still require some special handling of
codegen: when selecting the targets to operate on we have to
replace any codegen target roots with their corresponding
synthetic targets, as those are the ones with the actual sources
to publish.
This change also copies the old task's unit tests, except the
ones pertaining to codegen (which would no longer work without
setting up and running codegen tasks in the tests).
Instead, this change adds an integration test that ensures that we
create an appropriate sdist from codegen targets, thus exercising
the special handling mentioned above (and incidentally also verifying
that our new pipeline does do the right thing regarding synthesizing
library targets for generated code).