[jvm-compile] Copy compile classpath into runtime classpath even if a… #4310

Merged
merged 1 commit into from Mar 7, 2017

Conversation

Projects
None yet
4 participants
@baroquebobcat
Contributor

baroquebobcat commented Mar 6, 2017

…lready defined

In #4309, the problem was caused by jvm_compile assuming it is always first in the compile order. This ensures the compile_classpath is mixed into the runtime classpath even if it has already been initialized.

Another approach would be to move the NodeBuild task to later in the compile goal, and make it an error for jvm_compile to receive a runtime classpath.

[jvm-compile] Copy compile classpath into runtime classpath even if a…
…lready defined

In #4309, the problem was caused by jvm_compile assuming it is always first in the compile order. This ensures the compile_classpath is mixed into the runtime classpath even if it has already been initialized.

Another approach would be to move the NodeBuild task to later in the compile goal, and make it an error for jvm_compile to receive a runtime classpath.
@UnrememberMe

This comment has been minimized.

Show comment
Hide comment
@UnrememberMe

UnrememberMe Mar 6, 2017

Looks good to me.

Looks good to me.

@benjyw

benjyw approved these changes Mar 6, 2017

@ity

ity approved these changes Mar 7, 2017

thanks for fixing this!

@baroquebobcat baroquebobcat merged commit 8aeadcd into pantsbuild:master Mar 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

[jvm-compile] Copy compile classpath into runtime classpath even if a…
…lready defined (#4310)

#Problem
In #4309, the problem was caused by jvm_compile assuming it is always first in the compile order. 

#Solution

This patch ensures the compile_classpath is mixed into the runtime classpath even if it has already been initialized.

#Result

Fixes #4309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment