scrooge_gen task copy strict_deps field #4321

Merged
merged 1 commit into from Mar 10, 2017

Conversation

Projects
None yet
3 participants
@JieGhost
Contributor

JieGhost commented Mar 10, 2017

Problem

Currently, strict_deps field in java_thrift_target will not be copied to the generated synthetic target.

Solution

add 'strict_deps' into target attributes list to be copied.

@JieGhost JieGhost requested review from baroquebobcat, ity and peiyuwang Mar 10, 2017

@ity

ity approved these changes Mar 10, 2017

lgtm!

@JieGhost JieGhost merged commit 9f2d984 into pantsbuild:master Mar 10, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@JieGhost JieGhost deleted the JieGhost:yujieproject/java_thrift_library_strict_deps branch Mar 10, 2017

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

scrooge_gen task copy strict_deps field (#4321)
### Problem

Currently, strict_deps field in java_thrift_target will not be copied to the generated synthetic target.

### Solution

add 'strict_deps' into target attributes list to be copied.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment