Misc fixes to python tasks: #4323

Merged
merged 2 commits into from Mar 12, 2017

Conversation

Projects
None yet
2 participants
@benjyw
Contributor

benjyw commented Mar 10, 2017

  • PythonISortTask shouldn't be a PythonTask, as it uses none
    of the chroot-building facilities of that base class.

  • Fix a missing subsystem dep.

  • Remove an old template that is now consumed from another
    location.

  • Add the --fast option to the new PytestRun, even though it
    does nothing, because some scripts still reference it, and
    having it here, even as a no-op, will streamline the switch
    to the new pipeline in our repo.

  • Move PythonSetup/PythonRepos subsystems out of the python backend.
    This is a longstanding TODO: Pants needs these for plugin loading even
    if the repo contains no python code at all. So these belong in core
    pants, not in the python backend. Note that these are not public API, and
    their options scopes haven't changed, so this move does not require deprecation.

Misc fixes to python tasks:
- PythonISortTask shouldn't be a PythonTask, as it uses none
  of the chroot-building facilities of that base class.

- Fix a missing subsystem dep.

- Remove an old template that is now consumed from another
  location.

- Add the --fast option to the new PytestRun, even though it
  does nothing, because some scripts still reference it, and
  having it here, even as a no-op, will streamline the switch
  to the new pipeline in our repo.

@benjyw benjyw requested review from ity, kwlzn and jsirois Mar 12, 2017

@kwlzn

kwlzn approved these changes Mar 12, 2017

lgtm!

@benjyw

This comment has been minimized.

Show comment
Hide comment
@benjyw

benjyw Mar 12, 2017

Contributor

@kwlzn Thanks for the review - can you take a quick look at the second commit I added to this PR before I realized that you'd already reviewed and approved this...? Thanks.

Contributor

benjyw commented Mar 12, 2017

@kwlzn Thanks for the review - can you take a quick look at the second commit I added to this PR before I realized that you'd already reviewed and approved this...? Thanks.

Also move PythonSetup/PythonRepos subsystems out of the python backend.
This is a longstanding TODO: Pants needs these for plugin loading even
if the repo contains no python code at all. So these belong in core
pants, not in the python backend.

Note that these are not public API, and their options scopes
haven't changed, so this move does not require deprecation.
@kwlzn

kwlzn approved these changes Mar 12, 2017

lgtm!

@benjyw benjyw merged commit d56240c into pantsbuild:master Mar 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:new_python_tweaks branch Mar 12, 2017

@benjyw

This comment has been minimized.

Show comment
Hide comment
@benjyw

benjyw Mar 12, 2017

Contributor

Thanks for the quick turnaround!

Contributor

benjyw commented Mar 12, 2017

Thanks for the quick turnaround!

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

Misc fixes to python tasks: (#4323)
PythonISortTask shouldn't be a PythonTask, as it uses none
of the chroot-building facilities of that base class.

Fix a missing subsystem dep.

Remove an old template that is now consumed from another
location.

Add the --fast option to the new PytestRun, even though it
does nothing, because some scripts still reference it, and
having it here, even as a no-op, will streamline the switch
to the new pipeline in our repo.

Move PythonSetup/PythonRepos subsystems out of the python backend.
This is a longstanding TODO: Pants needs these for plugin loading even
if the repo contains no python code at all. So these belong in core
pants, not in the python backend. Note that these are not public API, and
their options scopes haven't changed, so this move does not require deprecation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment