Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[engine] Move to new-style CFFI callbacks. #4324
We currently use "old-style callbacks" with CFFI. These are known to be slower and cause more complicated stack traces during debugging/performance analysis.
Switch to "new-style callbacks" using the following approach:
This results in a single native-engine binary that can be loaded both as a python module (import) and as a C module (dlopen) and is not statically or dynamically linked to python.
As tested on my Sierra laptop, this is good for a >10% speedup as measured by
referenced this pull request
Mar 12, 2017
It looks pretty good to me. I've got a couple of things I'd like addressed / clarified.
Awesome. Thanks a lot for tackling this Kris!