Profile the pants invocations in integration tests. #4325

Merged
merged 2 commits into from Mar 13, 2017

Conversation

Projects
None yet
3 participants
@benjyw
Contributor

benjyw commented Mar 12, 2017

If the user asks for a perf profile (by setting PANTS_PROFILE) when
running an integration test, then they likely mean that they want
a profile of the invocation of pants in a subprocess, not of
the calling process.

This change passes the PANTS_PROFILE setting through to those
subprocesses, appropriately modified so that the child profile doesn't
stomp on that of the parent.

Profile the pants invocations in integration tests.
If the user asks for a perf profile (by setting PANTS_PROFILE) when
running an integration test then they likely mean that they want
a profile of the subprocess that invokes pants in the test environment.

This change makes sure those are written to auxiliary profile files.
@stuhood

Thanks Benjy.

@baroquebobcat

looks good to me.

@benjyw benjyw merged commit f574b6f into pantsbuild:master Mar 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:profile_int_test_subprocs branch Mar 13, 2017

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

Profile the pants invocations in integration tests. (#4325)
If the user asks for a perf profile (by setting PANTS_PROFILE) when
running an integration test then they likely mean that they want
a profile of the subprocess that invokes pants in the test environment.

This change makes sure those are written to auxiliary profile files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment