[engine] Skip cycle detection test #4361

Merged
merged 1 commit into from Mar 22, 2017

Conversation

Projects
None yet
3 participants
@peiyuwang
Contributor

peiyuwang commented Mar 22, 2017

Problem

We know #4349 is going to miss cycle detection, we already created #4358 to follow up. The issue is we didn't realize we have an integration test for it, so #4349 was checked in around the same time #4340, the former was only tested in v1, and the latter turned v2 on. Now master is broken.

Solution

Skip the failing test

Result

Will follow up with #4358 next for the proper fix.

@peiyuwang peiyuwang requested review from stuhood and kwlzn Mar 22, 2017

@kwlzn

kwlzn approved these changes Mar 22, 2017

lgtm!

@peiyuwang peiyuwang merged commit f17f327 into pantsbuild:master Mar 22, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@peiyuwang peiyuwang deleted the peiyuwang:peiyu/temporarily-skip-test-cycle branch Mar 22, 2017

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

Skip cycle detection test (#4361)
### Problem

We know #4349 is going to miss cycle detection, we already created #4358 to follow up. The issue is we didn't realize we have an integration test for it, so #4349 was checked in around the same time #4340, the former was only tested in v1, and the latter turned v2 on. Now master is broken.

### Solution

Skip the failing test

### Result

Will follow up with #4358 next for the proper fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment