New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair handling of resources kwargs for changed. #4396

Merged
merged 1 commit into from Mar 28, 2017

Conversation

Projects
None yet
2 participants
@kwlzn
Member

kwlzn commented Mar 28, 2017

This repairs the following traceback on a ./pants --enable-v2-engine changed --changed-parent=X --changed-include-dependees=transitive in our monorepo:

Exception caught: (<type 'exceptions.ValueError'>)
  File "/Users/kwilson/dev/pants/src/python/pants/bin/pants_exe.py", line 50, in <module>
    main()
  File "/Users/kwilson/dev/pants/src/python/pants/bin/pants_exe.py", line 44, in main
    PantsRunner(exiter).run()
  File "/Users/kwilson/dev/pants/src/python/pants/bin/pants_runner.py", line 57, in run
    options_bootstrapper=options_bootstrapper)
  File "/Users/kwilson/dev/pants/src/python/pants/bin/pants_runner.py", line 46, in _run
    return LocalPantsRunner(exiter, args, env, options_bootstrapper=options_bootstrapper).run()
  File "/Users/kwilson/dev/pants/src/python/pants/bin/local_pants_runner.py", line 37, in run
    self._run()
  File "/Users/kwilson/dev/pants/src/python/pants/bin/local_pants_runner.py", line 77, in _run
    self._exiter).setup()
  File "/Users/kwilson/dev/pants/src/python/pants/bin/goal_runner.py", line 193, in setup
    goals, context = self._setup_context(pantsd_launcher)
  File "/Users/kwilson/dev/pants/src/python/pants/bin/goal_runner.py", line 165, in _setup_context
    self._global_options.subproject_roots,
  File "/Users/kwilson/dev/pants/src/python/pants/bin/goal_runner.py", line 106, in _init_graph
    change_calculator=graph_helper.change_calculator)
  File "/Users/kwilson/dev/pants/src/python/pants/init/target_roots.py", line 73, in create
    changed_addresses = change_calculator.changed_target_addresses(changed_request)
  File "/Users/kwilson/dev/pants/src/python/pants/engine/legacy/change_calculator.py", line 128, in changed_target_addresses
    return list(self.iter_changed_target_addresses(changed_request))
  File "/Users/kwilson/dev/pants/src/python/pants/engine/legacy/change_calculator.py", line 107, in iter_changed_target_addresses
    in self._mapper.iter_target_addresses_for_sources(changed_files))
  File "/Users/kwilson/dev/pants/src/python/pants/engine/legacy/change_calculator.py", line 105, in <genexpr>
    changed_addresses = set(address
  File "/Users/kwilson/dev/pants/src/python/pants/engine/legacy/source_mapper.py", line 107, in iter_target_addresses_for_sources
    if any(source_file in sources_set for source_file in target_files_iter):
  File "/Users/kwilson/dev/pants/src/python/pants/engine/legacy/source_mapper.py", line 107, in <genexpr>
    if any(source_file in sources_set for source_file in target_files_iter):
  File "/Users/kwilson/dev/pants/src/python/pants/engine/legacy/source_mapper.py", line 89, in _iter_owned_files_from_hydrated_target
    raise ValueError('TODO: Not supported: see #4010.')

Exception message: TODO: Not supported: see #4010.

@kwlzn kwlzn requested review from stuhood and ity Mar 28, 2017

@kwlzn

This comment has been minimized.

Show comment
Hide comment
@kwlzn

kwlzn Mar 28, 2017

Member

expediting this based on successful local testing - will circle back with a proper test case.

Member

kwlzn commented Mar 28, 2017

expediting this based on successful local testing - will circle back with a proper test case.

@ity

ity approved these changes Mar 28, 2017

@ity

changes look good, will wait for tests

@kwlzn kwlzn merged commit 3615050 into pantsbuild:master Mar 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

peiyuwang added a commit to peiyuwang/pants that referenced this pull request Mar 29, 2017

Repair handling on resources kwargs for changed. (#4396)
This repairs the following traceback on a ./pants --enable-v2-engine changed --changed-parent=X --changed-include-dependees=transitive in our monorepo:

Exception caught: (<type 'exceptions.ValueError'>)
  File "/Users/kwilson/dev/pants/src/python/pants/bin/pants_exe.py", line 50, in <module>
    main()
  File "/Users/kwilson/dev/pants/src/python/pants/bin/pants_exe.py", line 44, in main
    PantsRunner(exiter).run()
  File "/Users/kwilson/dev/pants/src/python/pants/bin/pants_runner.py", line 57, in run
    options_bootstrapper=options_bootstrapper)
  File "/Users/kwilson/dev/pants/src/python/pants/bin/pants_runner.py", line 46, in _run
    return LocalPantsRunner(exiter, args, env, options_bootstrapper=options_bootstrapper).run()
  File "/Users/kwilson/dev/pants/src/python/pants/bin/local_pants_runner.py", line 37, in run
    self._run()
  File "/Users/kwilson/dev/pants/src/python/pants/bin/local_pants_runner.py", line 77, in _run
    self._exiter).setup()
  File "/Users/kwilson/dev/pants/src/python/pants/bin/goal_runner.py", line 193, in setup
    goals, context = self._setup_context(pantsd_launcher)
  File "/Users/kwilson/dev/pants/src/python/pants/bin/goal_runner.py", line 165, in _setup_context
    self._global_options.subproject_roots,
  File "/Users/kwilson/dev/pants/src/python/pants/bin/goal_runner.py", line 106, in _init_graph
    change_calculator=graph_helper.change_calculator)
  File "/Users/kwilson/dev/pants/src/python/pants/init/target_roots.py", line 73, in create
    changed_addresses = change_calculator.changed_target_addresses(changed_request)
  File "/Users/kwilson/dev/pants/src/python/pants/engine/legacy/change_calculator.py", line 128, in changed_target_addresses
    return list(self.iter_changed_target_addresses(changed_request))
  File "/Users/kwilson/dev/pants/src/python/pants/engine/legacy/change_calculator.py", line 107, in iter_changed_target_addresses
    in self._mapper.iter_target_addresses_for_sources(changed_files))
  File "/Users/kwilson/dev/pants/src/python/pants/engine/legacy/change_calculator.py", line 105, in <genexpr>
    changed_addresses = set(address
  File "/Users/kwilson/dev/pants/src/python/pants/engine/legacy/source_mapper.py", line 107, in iter_target_addresses_for_sources
    if any(source_file in sources_set for source_file in target_files_iter):
  File "/Users/kwilson/dev/pants/src/python/pants/engine/legacy/source_mapper.py", line 107, in <genexpr>
    if any(source_file in sources_set for source_file in target_files_iter):
  File "/Users/kwilson/dev/pants/src/python/pants/engine/legacy/source_mapper.py", line 89, in _iter_owned_files_from_hydrated_target
    raise ValueError('TODO: Not supported: see #4010.')

Exception message: TODO: Not supported: see #4010.

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

Repair handling on resources kwargs for changed. (#4396)
This repairs the following traceback on a ./pants --enable-v2-engine changed --changed-parent=X --changed-include-dependees=transitive in our monorepo:

Exception caught: (<type 'exceptions.ValueError'>)
  File "/Users/kwilson/dev/pants/src/python/pants/bin/pants_exe.py", line 50, in <module>
    main()
  File "/Users/kwilson/dev/pants/src/python/pants/bin/pants_exe.py", line 44, in main
    PantsRunner(exiter).run()
  File "/Users/kwilson/dev/pants/src/python/pants/bin/pants_runner.py", line 57, in run
    options_bootstrapper=options_bootstrapper)
  File "/Users/kwilson/dev/pants/src/python/pants/bin/pants_runner.py", line 46, in _run
    return LocalPantsRunner(exiter, args, env, options_bootstrapper=options_bootstrapper).run()
  File "/Users/kwilson/dev/pants/src/python/pants/bin/local_pants_runner.py", line 37, in run
    self._run()
  File "/Users/kwilson/dev/pants/src/python/pants/bin/local_pants_runner.py", line 77, in _run
    self._exiter).setup()
  File "/Users/kwilson/dev/pants/src/python/pants/bin/goal_runner.py", line 193, in setup
    goals, context = self._setup_context(pantsd_launcher)
  File "/Users/kwilson/dev/pants/src/python/pants/bin/goal_runner.py", line 165, in _setup_context
    self._global_options.subproject_roots,
  File "/Users/kwilson/dev/pants/src/python/pants/bin/goal_runner.py", line 106, in _init_graph
    change_calculator=graph_helper.change_calculator)
  File "/Users/kwilson/dev/pants/src/python/pants/init/target_roots.py", line 73, in create
    changed_addresses = change_calculator.changed_target_addresses(changed_request)
  File "/Users/kwilson/dev/pants/src/python/pants/engine/legacy/change_calculator.py", line 128, in changed_target_addresses
    return list(self.iter_changed_target_addresses(changed_request))
  File "/Users/kwilson/dev/pants/src/python/pants/engine/legacy/change_calculator.py", line 107, in iter_changed_target_addresses
    in self._mapper.iter_target_addresses_for_sources(changed_files))
  File "/Users/kwilson/dev/pants/src/python/pants/engine/legacy/change_calculator.py", line 105, in <genexpr>
    changed_addresses = set(address
  File "/Users/kwilson/dev/pants/src/python/pants/engine/legacy/source_mapper.py", line 107, in iter_target_addresses_for_sources
    if any(source_file in sources_set for source_file in target_files_iter):
  File "/Users/kwilson/dev/pants/src/python/pants/engine/legacy/source_mapper.py", line 107, in <genexpr>
    if any(source_file in sources_set for source_file in target_files_iter):
  File "/Users/kwilson/dev/pants/src/python/pants/engine/legacy/source_mapper.py", line 89, in _iter_owned_files_from_hydrated_target
    raise ValueError('TODO: Not supported: see #4010.')

Exception message: TODO: Not supported: see #4010.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment