Bring back --no-fast mode in pytest run. #4491

Merged
merged 2 commits into from Apr 20, 2017

Conversation

Projects
None yet
3 participants
@benjyw
Contributor

benjyw commented Apr 19, 2017

Note however that this is a little different from the previous
implementation in the old backend. The old implementation allowed
you to run tests with conflicting requirements in a single pants
invocation. This implementation allows you to run each test in its
own pytest invocation, so that tests in other targets can't pollute
a test's environmnent, but all targets in a single invocation must
still be able to resolve their requirements together.

In the future we hope to add back the ability to run multiple
conflicting tests in a single invocation of Pants, but that is
out of scope for this change.

Bring back --no-fast mode in pytest run.
Note however that this is a little different from the previous
implementation in the old backend.  The old implementation allowed
you to run tests with conflicting requirements in a single pants
invocation. This implementation allows you to run each test in its
own pytest invocation, so that tests in other targets can't pollute
a test's environmnent, but all targets in a single invocation must
still be able to resolve their requirements together.

In the future we hope to add back the ability to run multiple
conflicting tests in a single invocation of Pants, but that is
out of scope for this change.

@benjyw benjyw requested review from kwlzn and stuhood Apr 19, 2017

@kwlzn

kwlzn approved these changes Apr 20, 2017

lgtm

@stuhood

Thanks Benjy!

- 'isolation verifies that all dependencies are correctly declared.')
+ help='Run all tests in a single pytest invocation. If turned off, each test target '
+ 'will run in its own pytest invocation, which will be slower, but isolates '
+ 'tests from process-wide state created by test in other targets.')

This comment has been minimized.

@stuhood

stuhood Apr 20, 2017

Member

created by tests

@stuhood

stuhood Apr 20, 2017

Member

created by tests

@benjyw benjyw merged commit 1c8ef0b into pantsbuild:master Apr 20, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@benjyw benjyw deleted the benjyw:restore_fast_mode branch Apr 20, 2017

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

Bring back --no-fast mode in pytest run. (#4491)
Note however that this is a little different from the previous
implementation in the old backend.  The old implementation allowed
you to run tests with conflicting requirements in a single pants
invocation. This implementation allows you to run each test in its
own pytest invocation, so that tests in other targets can't pollute
a test's environmnent, but all targets in a single invocation must
still be able to resolve their requirements together.

In the future we hope to add back the ability to run multiple
conflicting tests in a single invocation of Pants, but that is
out of scope for this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment