New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default `Fetcher.ProgressListener` to stderr. #4499

Merged
merged 2 commits into from Apr 21, 2017

Conversation

Projects
None yet
2 participants
@jsirois
Member

jsirois commented Apr 20, 2017

Add a basic unit test for the ProgressListener as well.

Closes #4370

Default `Fetcher.ProgressListener` to stderr.
Add a basic unit test for the `ProgressListener` as well.
@kwlzn

kwlzn approved these changes Apr 21, 2017

lgtm! one quick change request inline.

Show outdated Hide outdated src/python/pants/net/http/fetcher.py

@jsirois jsirois merged commit 2a58465 into pantsbuild:master Apr 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:jsirois/issues/4370 branch Apr 21, 2017

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

Default `Fetcher.ProgressListener` to stderr. (#4499)
Add a basic unit test for the `ProgressListener` as well.

Closes #4370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment