Make go targets work with v2 changed. #4500

Merged
merged 3 commits into from Apr 21, 2017

Conversation

Projects
None yet
2 participants
@kwlzn
Member

kwlzn commented Apr 21, 2017

Fixes #4393.

Problem

Currently, go targets (e.g. go_binary) fail to be detected by the v2 engine changed implementation due to no TargetAdaptor coverage.

Solution

Add TargetAdaptor coverage and an integration test. This required plumbing an explicit sources= kwarg for GoLocalSource and subclasses, which is hopefully ok now that default sources are the norm.

Result

Integration test now passes.

@kwlzn kwlzn changed the title from Make go targets with default sources work with v2 changed. to Make go targets work with v2 changed. Apr 21, 2017

@kwlzn kwlzn requested review from jsirois, JieGhost and stuhood Apr 21, 2017

@kwlzn kwlzn merged commit 7f3b942 into pantsbuild:master Apr 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

Make go targets work with v2 changed. (#4500)
Fixes #4393.

Problem

Currently, go targets (e.g. go_binary) fail to be detected by the v2 engine changed implementation due to no TargetAdaptor coverage.

Solution

Add TargetAdaptor coverage and an integration test. This required plumbing an explicit sources= kwarg for GoLocalSource and subclasses, which is hopefully ok now that default sources are the norm.

Result

Integration test now passes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment