Fix some incorrectly formatted dev release semvers. #4501

Merged
merged 2 commits into from Apr 21, 2017

Conversation

Projects
None yet
3 participants
@benjyw
Contributor

benjyw commented Apr 21, 2017

Also modifies the release docs to clarify the format.

Fix some incorrectly formatted dev release semvers.
Also modifies the release docs to clarify the format.

@benjyw benjyw requested review from stuhood and mateor Apr 21, 2017

@benjyw

This comment has been minimized.

Show comment
Hide comment
@benjyw

benjyw Apr 21, 2017

Contributor

I think this is correct, no?

Contributor

benjyw commented Apr 21, 2017

I think this is correct, no?

@benjyw benjyw assigned kwlzn and unassigned kwlzn Apr 21, 2017

@benjyw benjyw requested a review from kwlzn Apr 21, 2017

src/docs/release_strategy.md
## Examples
* Leading up to the release of `2.0.0` the release manager would create a `stable` branch with
-the literal name "`2.0.x`". They would cut release candidates named `2.0.0rc0` (and so on), and
+the literal name "`2.0.x`". They would cut release candidates named `2.0.0.rc0` (and so on), and

This comment has been minimized.

@jsirois

jsirois Apr 21, 2017

Member

If I read this correctly, the . should not precede rcN, unlike for devN where it should: https://www.python.org/dev/peps/pep-0440/#public-version-identifiers

Python versioning is not exactly semver versioning.

@jsirois

jsirois Apr 21, 2017

Member

If I read this correctly, the . should not precede rcN, unlike for devN where it should: https://www.python.org/dev/peps/pep-0440/#public-version-identifiers

Python versioning is not exactly semver versioning.

Fix rc versioning.
Link to rationale.
@benjyw

This comment has been minimized.

Show comment
Hide comment
@benjyw

benjyw Apr 21, 2017

Contributor

Good to know. Fixed and linked to that doc in our docs.

Contributor

benjyw commented Apr 21, 2017

Good to know. Fixed and linked to that doc in our docs.

@kwlzn

kwlzn approved these changes Apr 21, 2017

@benjyw benjyw merged commit b0659af into pantsbuild:master Apr 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:fix_dev_semvers branch Apr 21, 2017

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

Fix some incorrectly formatted dev release semvers. (#4501)
Also modifies the release docs to clarify the format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment