Make usage of pantsd imply usage of watchman #4512

Merged
merged 1 commit into from Apr 24, 2017

Conversation

Projects
None yet
2 participants
@stuhood
Member

stuhood commented Apr 24, 2017

Problem

The pants daemon is only useful in the context of the --fs-event-detection flag, but usage of that flag is currently optional.

Solution

Deprecate that flag, such that usage of --enable-pantsd implies --fs-event-detection.

@stuhood stuhood requested a review from kwlzn Apr 24, 2017

@kwlzn

kwlzn approved these changes Apr 24, 2017

lgtm! thanks Stu.

@stuhood stuhood merged commit b5eaf05 into pantsbuild:master Apr 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/deprecate-fs-event-detection-flag branch Apr 24, 2017

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

Make usage of pantsd imply usage of watchman. (#4512)
### Problem

The pants daemon is only useful in the context of the `--fs-event-detection` flag, but usage of that flag is currently optional.

### Solution

Deprecate that flag, such that usage of `--enable-pantsd` implies `--fs-event-detection`.

thesamet added a commit to thesamet/pants that referenced this pull request May 9, 2017

Make usage of pantsd imply usage of watchman. (#4512)
### Problem

The pants daemon is only useful in the context of the `--fs-event-detection` flag, but usage of that flag is currently optional.

### Solution

Deprecate that flag, such that usage of `--enable-pantsd` implies `--fs-event-detection`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment