Add a scala specs2 example #4516

Merged
merged 9 commits into from Apr 27, 2017

Conversation

Projects
None yet
3 participants
@wisechengyi
Contributor

wisechengyi commented Apr 25, 2017

Adding a specs2 example, so it is more clear how it can be used. Also tested in an IntelliJ project, the tests run as expected as well in both IntelliJ JUnit runner and specs2 runner.

Example:

$ ./pants test examples/tests/scala/org/pantsbuild/example/specs2/
...
00:12:49 00:02     [junit]
00:12:49 00:02       [run]
                     Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
                     Java HotSpot(TM) 64-Bit Server VM warning: ignoring option UseSplitVerifier; support was removed in 8.0
                     Auto-detected 8 processors, using -parallel-threads=8
                     ....
                     Time: 0
                     
                     OK (0 tests)
                     
                     
                     Time: 0.164
                     
                     OK (2 tests)
                     
                     
00:12:50 00:03     [go]
00:12:50 00:03     [node]
00:12:50 00:03   [complete]
               SUCCESS

@wisechengyi wisechengyi referenced this pull request in pantsbuild/intellij-pants-plugin Apr 25, 2017

Closed

Cannot run specs2 test from within IDEA pants project #289

@wisechengyi wisechengyi changed the title from (wip) specs2 examples to Add a scala spec2 example Apr 27, 2017

@wisechengyi wisechengyi changed the title from Add a scala spec2 example to Add a scala specs2 example Apr 27, 2017

@wisechengyi wisechengyi requested review from stuhood, jsirois and benjyw Apr 27, 2017

+junit_tests(
+ dependencies=[
+ '3rdparty/jvm/org/specs2:specs2-junit_2.11',
+ '3rdparty:junit',

This comment has been minimized.

@jsirois

jsirois Apr 27, 2017

Member

I thought the junit jar dep was auto-injected by the junit_tests target, making this dep un-needed / redundant.

@jsirois

jsirois Apr 27, 2017

Member

I thought the junit jar dep was auto-injected by the junit_tests target, making this dep un-needed / redundant.

This comment has been minimized.

@wisechengyi

wisechengyi Apr 27, 2017

Contributor

thanks! corrected.

@wisechengyi

wisechengyi Apr 27, 2017

Contributor

thanks! corrected.

@baroquebobcat

This comment has been minimized.

Show comment
Hide comment
@baroquebobcat

baroquebobcat Apr 27, 2017

Contributor

Could you add a short README to this?

Contributor

baroquebobcat commented Apr 27, 2017

Could you add a short README to this?

@wisechengyi

This comment has been minimized.

Show comment
Hide comment
@wisechengyi

wisechengyi Apr 27, 2017

Contributor

@baroquebobcat Done. Thanks for the suggestion!

Contributor

wisechengyi commented Apr 27, 2017

@baroquebobcat Done. Thanks for the suggestion!

@wisechengyi wisechengyi merged commit 8b3395c into pantsbuild:master Apr 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wisechengyi wisechengyi deleted the wisechengyi:specs2 branch Apr 27, 2017

thesamet added a commit to thesamet/pants that referenced this pull request May 9, 2017

Add a scala specs2 example (#4516)
Adding a specs2 example, so it is more clear how it can be used. Also tested in an IntelliJ project, the tests run as expected as well in both IntelliJ JUnit runner and specs2 runner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment