Fix the kythe bootclasspath. #4527

Merged
merged 1 commit into from Apr 28, 2017

Conversation

Projects
None yet
2 participants
@benjyw
Contributor

benjyw commented Apr 27, 2017

We must load the Java 9 versions of com.sun.tools.javac
and javax.tools embedded in the Kythe jars, and not the
runtime's versions.

A recent Kythe change exposed this problem. Unclear why it
didn't bite us before.

Fix the kythe bootclasspath.
We must load the Java 9 versions of com.sun.tools.javac
and javax.tools embedded in the Kythe jars, and not the
runtime's versions.

A recent Kythe change exposed this problem. Unclear why it
didn't bite us before.

@benjyw benjyw requested a review from stuhood Apr 27, 2017

@benjyw benjyw merged commit a865903 into pantsbuild:master Apr 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:kythe_fix branch Apr 28, 2017

thesamet added a commit to thesamet/pants that referenced this pull request May 9, 2017

Fix the kythe bootclasspath. (#4527)
We must load the Java 9 versions of com.sun.tools.javac
and javax.tools embedded in the Kythe jars, and not the
runtime's versions.

A recent Kythe change exposed this problem. Unclear why it
didn't bite us before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment