Move scalastyle and java checkstyle into the `lint` goal #4540

Merged
merged 2 commits into from May 2, 2017

Conversation

Projects
None yet
3 participants
@stuhood
Member

stuhood commented May 2, 2017

Problem

The scalastyle and java checkstyle goals used to be shipped as optional tasks that consumers would (presumably) install in the compile goal in their repos. Over time, other forms of checkstyle were moved into various backends and were installed as non-optional, but enabling scalastyle and checkstyle in compile would have broken existing codebases.

Solution

Now that we have a lint goal, enabling these by default in that goal makes sense. Users who were manually installing them elsewhere can continue to do that.

Result

Fixes #4537.

@stuhood stuhood requested review from baroquebobcat, cheister and benjyw May 2, 2017

@benjyw

benjyw approved these changes May 2, 2017

Two thumbs up!

@stuhood stuhood merged commit b04ce10 into pantsbuild:master May 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/move-checkstyle-and-scalastyle-to-lint branch May 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment