[engine] Dockerize native engine builds #4554

Merged
merged 1 commit into from May 6, 2017

Conversation

Projects
None yet
2 participants
@kwlzn
Member

kwlzn commented May 5, 2017

Fixes #4541

Problem

Native engine builds dynamically link against libc. This can be problematic if the published binaries are built on a platform with a newer version of libc than the runtime platform.

Solution

In order for the native engine to run on older platforms, we need to link against the oldest reasonable libc at binary creation time and rely on forward compatibility/OS compatibility libraries to cover more possible platforms.

Result

More widely compatible native engine binaries.

@kwlzn kwlzn changed the title from [engine] Dockerize native engine builds to [WIP][engine] Dockerize native engine builds May 5, 2017

@kwlzn kwlzn changed the title from [WIP][engine] Dockerize native engine builds to [engine] Dockerize native engine builds May 6, 2017

@kwlzn kwlzn requested review from stuhood and jsirois May 6, 2017

@kwlzn

This comment has been minimized.

Show comment
Hide comment
@kwlzn

kwlzn May 6, 2017

Member

noting that I'm not exactly sure how to test the deploy aspect of this change other than landing and fixing-forward if needed. cc @jsirois in case he has any tips/tricks or other guidance there.

Member

kwlzn commented May 6, 2017

noting that I'm not exactly sure how to test the deploy aspect of this change other than landing and fixing-forward if needed. cc @jsirois in case he has any tips/tricks or other guidance there.

@stuhood

stuhood approved these changes May 6, 2017

This is awesome. Should speed things up to only do it once too.

Thanks!

@kwlzn kwlzn merged commit 26880d2 into pantsbuild:master May 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment