Ignore dot-directories by default #4556

Merged
merged 2 commits into from May 6, 2017

Conversation

Projects
None yet
2 participants
@stuhood
Member

stuhood commented May 6, 2017

Problem

#4547 showed that ignoring all dot-files by default is not a good choice... and the majority of the filesystem access that is avoided by ignoring dot-files is actually due to ignoring dot-directories.

Solution

Ignore only dot-directories by default. Additionally, restrict a few default patterns that should definitely only match directories to directories.

Result

Fixes #4547.

In the medium term, we should absolutely support using the .gitignore file for this (especially since it's trivial in the rust code), but currently it would involve lots of edits in deprecated code paths, and I'd like to avoid significant changes immediately before 1.3.0.

Restrict dot-file ignoring to dot-directories by default; require tha…
…t other default ignores are directories as well.

@stuhood stuhood requested review from benjyw, wisechengyi and kwlzn May 6, 2017

@kwlzn

kwlzn approved these changes May 6, 2017

lgtm!

@stuhood stuhood merged commit 62997d0 into pantsbuild:master May 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/ignore-only-dot-directories-by-default branch May 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment