Warn when implicit_sources would be used, but is disabled #4559

Merged
merged 3 commits into from May 6, 2017

Conversation

Projects
None yet
2 participants
@stuhood
Member

stuhood commented May 6, 2017

Problem

As described on #4439, implicit_sources are a fantastic feature, but need to be enabled carefully. Targets which pass no sources arg currently (and which rely on that resulting in the empty set of sources) would be broken by turning on implicit_sources by default.

Additionally, the implicit_sources arg was not implemented in the v2 engine, so implicit_sources were always enabled there.

Solution

Add support for the implicit_sources arg in v2, and warn on a target-by-target basis if implicit_sources is not enabled, and no sources were passed.

Result

Fixes the issue with v2 not supporting the implicit_sources option, and opens the door to fixing #4439 in the future.

@stuhood stuhood requested review from benjyw, ity and kwlzn May 6, 2017

@kwlzn

kwlzn approved these changes May 6, 2017

lgtm

@stuhood stuhood merged commit 5960bb7 into pantsbuild:master May 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/implicit-sources-warn-on-empty branch May 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment