Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Include API that will store target info in run_tracker #4561
We would like to collect stats about the targets and tests being run so we would like to add a way to track this info.
The change included some refactoring to ease code re-use, a method to parse all the test information from the xml files, and two additional methods to collect target info and test info.
The changes shouldn't affect the end-user behavior. This change is for future development.
Hi @dotordogh - the code looks good, as far as I can tell. What is lacking is appropriate documentation. If I'm having trouble figuring out what all this does, and how it works, then the casual reader will too. Admittedly, I'm not putting a lot of energy into figuring it out, but then I shouldn't really have to...
Once this is appropriately documented, I'll take another look at the logic itself. :)
Thanks for the comprehensive documentation! Things are much clearer now. Still have a few comments.
Doc and implementation changes look good, but I have some remaining comments about the behavior of updates of this nested dict data structure. There seems to be some confusion. E.g., unless I'm drastically misreading things, the current code is not capable of producing the multi-scope example you give in the comment!
This really needs a unit test, to prove that its behavior is as expected (and to establish what those expectations are...)