New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[engine] Reuse scheduler's graph during validation pass #4566

Merged
merged 1 commit into from May 9, 2017

Conversation

Projects
None yet
2 participants
@baroquebobcat
Copy link
Contributor

baroquebobcat commented May 8, 2017

Problem

Creating a fresh rule graph for validation isn't necessary. Also, using a fresh one has the potential for allowing the graph that is validated to differ from the used graph.

Solution

Reuse the scheduler's rule graph during validation.

Result

Pants no longer constructs an extra graph and the interface has fewer params.

See #4551

@stuhood

stuhood approved these changes May 8, 2017

Copy link
Member

stuhood left a comment

Thanks!

@baroquebobcat baroquebobcat merged commit 6969352 into pantsbuild:master May 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

stuhood added a commit that referenced this pull request May 12, 2017

[engine] Don't recreate a graph just for validation (#4566)
### Problem

Creating a fresh rule graph for validation isn't necessary. Also, using a fresh one has the potential for allowing the graph that is validated to differ from the used graph.

### Solution

Reuse the scheduler's rule graph during validation.

### Result

Pants no longer constructs an extra graph and the interface has fewer params.

See #4551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment