Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix splitting of the build_flags. #4580
left a comment
I still think that converting this to a list option might be less error prone, and provide other benefits (like the ability to extend the set of options across multiple config files: see http://www.pantsbuild.org/options.html#list-options).
What are your thoughts on the matter?
TBH I don't like the option part at all. It makes it hard to see what option you are actually passing. In the context of an config file it might be okay (like in a yaml file, sure make it a list, since it is a list). But here it is a list of options that belong together and are build_flags.
I agree that the quote removal should probably go to the options parser. But then I don't see why we'd need a helper method beyond what safe_shlex_split() does.
I think the expectation is that options like these are generally passed via
(...I might not have manually lexed that correctly, but you get the idea.)