Fix export-classpath exclude behavior #4592

Merged
merged 1 commit into from May 15, 2017

Conversation

Projects
None yet
3 participants
@baroquebobcat
Contributor

baroquebobcat commented May 15, 2017

Problem

Excluded jars were being included in the manifest jar created by export-classpath.

Solution

Use the root targets as the starting point instead of the full closure when generating the classpath. When the whole closure was passed, it meant that even the jar_library targets were treated as root targets for the purposes of applying excludes, which meant that the least constrained excludes were always used.

Result

Excludes are properly respected by classpaths from export-classpath.

Fix export-classpaths exclude behavior
### Problem

Excluded jars were being included in the manifest jar created by export-classpath.

### Solution

Use the root targets as the starting point instead of the full closure when generating the classpath. When the whole closure was passed, it meant that even the jar_library targets were treated as root targets for the purposes of applying excludes, which meant that the least constrained excludes were always used.

### Result

Excludes are properly respected by classpaths from export-classpath

@stuhood stuhood added this to the 1.3.0 milestone May 15, 2017

@wisechengyi

Thanks Nick!

@baroquebobcat baroquebobcat merged commit abc77b2 into pantsbuild:master May 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

stuhood added a commit that referenced this pull request May 18, 2017

Fix export-classpaths exclude behavior (#4592)
### Problem

Excluded jars were being included in the manifest jar created by export-classpath.

### Solution

Use the root targets as the starting point instead of the full closure when generating the classpath. When the whole closure was passed, it meant that even the jar_library targets were treated as root targets for the purposes of applying excludes, which meant that the least constrained excludes were always used.

### Result

Excludes are properly respected by classpaths from export-classpath
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment