Switch to a conditional deprecation for the list-targets behaviour change #4600

Merged
merged 1 commit into from May 16, 2017

Conversation

Projects
None yet
4 participants
@stuhood
Member

stuhood commented May 16, 2017

Problem

The behaviour of scanning the entire repo when ./pants list is called with no arguments is going away. We had a warning in place, but because ./pants list is a console task, all logging was silenced.

Solution

The warning should actually be a deprecation anyway, so switch to deprecated conditional. Additionally, make an executive decision as to the final behaviour: ./pants list doing nothing at all would be more confusing than just throwing an error, so let's commit to throwing an error in the future.

Result

Fixes #4597.

@baroquebobcat

lgtm.

@stuhood stuhood merged commit eaf036b into pantsbuild:master May 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/switch-to-conditional branch May 16, 2017

stuhood added a commit that referenced this pull request May 18, 2017

Switch to a conditional deprecation for the list-targets behaviour ch…
…ange. (#4600)

### Problem

The behaviour of scanning the entire repo when `./pants list` is called with no arguments is going away. We had a warning in place, but because `./pants list` is a console task, all logging was silenced.

### Solution

The warning should actually be a deprecation anyway, so switch to deprecated conditional. Additionally, make an executive decision as to the final behaviour: `./pants list` doing nothing at all would be more confusing than just throwing an error, so let's commit to throwing an error in the future.

### Result

Fixes #4597.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment