New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't register newpython tasks in the oldpython backend #4602

Merged
merged 2 commits into from May 18, 2017

Conversation

Projects
None yet
3 participants
@stuhood
Copy link
Member

stuhood commented May 16, 2017

Problem

The "oldpython" backend (which we are slowly weaning ourselves off of at Twitter) still registers some "newpython" tasks, which take up a non-trivial amount of time that we noticed in our benchmark suite during release prep.

Solution

Remove them.

@stuhood stuhood added this to the 1.3.0 milestone May 16, 2017

@stuhood stuhood requested a review from benjyw May 16, 2017

@stuhood stuhood self-assigned this May 17, 2017

@benjyw

benjyw approved these changes May 18, 2017

Copy link
Contributor

benjyw left a comment

LGTM

@stuhood stuhood merged commit fe1c2ab into pantsbuild:master May 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/dont-register-newpython-tasks-in-old-backend branch May 18, 2017

stuhood added a commit that referenced this pull request May 18, 2017

Don't register newpython tasks in the oldpython backend (#4602)
### Problem

The "oldpython" backend (which we are slowly weaning ourselves off of at Twitter) still registers some "newpython" tasks, which take up a non-trivial amount of time that we noticed in our benchmark suite during release prep.

### Solution

Remove them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment