New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass env vars through in ./pants run for python #4606

Merged
merged 3 commits into from May 18, 2017

Conversation

Projects
None yet
3 participants
@stuhood
Copy link
Member

stuhood commented May 18, 2017

Problem

As explained in #4590, environment variables are not passed to the pex-invoked subprocess during ./pants run in the python backend. That is a behaviour change from python_old.

Solution

Copy and propagate the environment into pex.run.

Result

Environment variables are passed through to the subprocess during ./pants run. Fixes #4590.

@stuhood stuhood added this to the 1.3.0 milestone May 18, 2017

@stuhood stuhood requested review from benjyw , wisechengyi and kwlzn May 18, 2017

@stuhood stuhood changed the title Stuhood/pass env vars through in run Pass env vars through in ./pants run for python May 18, 2017

@benjyw

benjyw approved these changes May 18, 2017

@stuhood stuhood merged commit 78be2f6 into pantsbuild:master May 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/pass-env-vars-through-in-run branch May 18, 2017

stuhood added a commit that referenced this pull request May 19, 2017

Pass env vars through in ./pants run for python (#4606)
### Problem

As explained in #4590, environment variables are not passed to the pex-invoked subprocess during `./pants run` in the python backend. That is a behaviour change from `python_old`.

### Solution

Copy and propagate the environment into `pex.run`.

### Result

Environment variables are passed through to the subprocess during `./pants run`. Fixes #4590.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment