Revert "Enable --compile-zinc-use-classpath-jars by default (#4525)" #4607

Merged
merged 2 commits into from May 19, 2017

Conversation

Projects
None yet
2 participants
@baroquebobcat
Contributor

baroquebobcat commented May 18, 2017

Problem

With the 1.0.0-X5 version of sbt, there's a case where having use-classpath-jars enabled causes runtime failures because zinc/sbt incorrectly detect interface changes. (See #4596).

Solution

Revert the commit making use-classpath-jars the default: 94775d9.

Result

#4596 is fixed.

@baroquebobcat baroquebobcat requested a review from stuhood May 18, 2017

@stuhood

Thanks for the investigation Nick.

build-support/bin/isort.sh
@@ -33,4 +33,4 @@ do
esac
done
-./pants -q --changed-parent=master fmt.isort -- ${isort_args[@]}
+./pants -q --changed-parent=HEAD fmt.isort -- ${isort_args[@]}

This comment has been minimized.

@stuhood

stuhood May 18, 2017

Member

Can you drop this from the commit? (oh, irony.)

@stuhood

stuhood May 18, 2017

Member

Can you drop this from the commit? (oh, irony.)

This comment has been minimized.

@baroquebobcat

baroquebobcat May 18, 2017

Contributor

Done.

@baroquebobcat

baroquebobcat May 18, 2017

Contributor

Done.

@stuhood stuhood added this to the 1.3.0 milestone May 18, 2017

@stuhood stuhood merged commit 17057e8 into pantsbuild:master May 19, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

stuhood added a commit that referenced this pull request May 19, 2017

Revert "Enable --compile-zinc-use-classpath-jars by default" (#4607)
### Problem

With the 1.0.0-X5 version of sbt, there's a case where having use-classpath-jars enabled causes runtime failures because zinc/sbt incorrectly detect interface changes. (See #4596).

### Solution

Revert the commit making use-classpath-jars the default: 94775d9.

### Result

#4596 is fixed.
@baroquebobcat

This comment has been minimized.

Show comment
Hide comment
@baroquebobcat

baroquebobcat May 19, 2017

Contributor
Contributor

baroquebobcat commented May 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment