New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression test for #4596 #4608

Merged
merged 4 commits into from May 17, 2018

Conversation

Projects
None yet
2 participants
@baroquebobcat
Copy link
Contributor

baroquebobcat commented May 18, 2017

Problem

We didn't have test coverage for source compatible, binary incompatible incremental changes for compiles with zinc.

Solution

Add a test case that covers it.

Result

If #4596 comes up again, it should be caught in the tests.

Note

This will fail the first CI because I'm waiting on #4607


config = {
'cache.compile.zinc': {'write_to': [cache_dir], 'read_from': [cache_dir]},
'compile.zinc': {'incremental_caching': True },

This comment has been minimized.

@stuhood

stuhood May 19, 2017

Member

Hm... incremental_caching shouldn't be necessary to catch this, right? Should be possible to repro without the cache at all (at least according to the report).

This comment has been minimized.

@baroquebobcat

baroquebobcat May 19, 2017

Contributor

hm. Probably not. I cribbed off of a similar test--might be unnecessary.

@stuhood stuhood force-pushed the pantsbuild:master branch from b6bb42d to 9e2fdb5 May 11, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented May 13, 2018

@baroquebobcat : Now that the zinc upgrade has landed, would you mind freshening this one up? Would like to try again at turning on using jars as zinc inputs.

@baroquebobcat

This comment has been minimized.

Copy link
Contributor

baroquebobcat commented May 15, 2018

resolving conflicts and re-running

@stuhood stuhood merged commit ffdede5 into pantsbuild:master May 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment