New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new `PytestRun` task deselction handling. #4648

Merged
merged 1 commit into from Jun 6, 2017

Conversation

Projects
None yet
4 participants
@jsirois
Copy link
Member

jsirois commented Jun 6, 2017

Old versions of py.test used by the old PytestRun task exited 0 when
no tests were found, new versions exit 5. Handle this case in the new
PytestRun task and add tests for the out of band test deselection
behavior for both new and old PytestRun tasks.

Fixes #4647

Fix new `PytestRun` task deselction handling.
Old versions of `py.test` used by the old `PytestRun` task exited 0 when
no tests were found, new versions exit 5. Handle this case in the new
`PytestRun` task and add tests for the out of band test deselection
behavior for both new and old `PytestRun` tasks.

Fixes #4647

@jsirois jsirois requested a review from benjyw Jun 6, 2017

@jsirois jsirois assigned kwlzn and unassigned kwlzn Jun 6, 2017

@jsirois jsirois requested a review from kwlzn Jun 6, 2017

@benjyw

benjyw approved these changes Jun 6, 2017

@kwlzn

kwlzn approved these changes Jun 6, 2017

Copy link
Member

kwlzn left a comment

lgtm!

@jsirois jsirois merged commit c7137d2 into pantsbuild:master Jun 6, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@jsirois jsirois deleted the jsirois:jsirois/issues/4647 branch Jun 6, 2017

@jsirois jsirois added this to the 1.3.1 milestone Jun 7, 2017

stuhood added a commit that referenced this pull request Jun 27, 2017

Fix new `PytestRun` task deselction handling. (#4648)
Old versions of `py.test` used by the old `PytestRun` task exited 0 when
no tests were found, new versions exit 5. Handle this case in the new
`PytestRun` task and add tests for the out of band test deselection
behavior for both new and old `PytestRun` tasks.

Fixes #4647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment