New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve transitive package checking in python resolver tests. #4738

Merged
merged 1 commit into from Jul 12, 2017

Conversation

Projects
None yet
2 participants
@kwlzn
Copy link
Member

kwlzn commented Jul 10, 2017

Problem

Currently, tests/python/pants_test/backend/python/tasks2/test_resolve_requirements.py::ResolveRequirementsTest::test_resolve_multiplatform_requirements performs a version-constrained check against an unpinned transitive dependency of CFFI. When new versions of this dep are released on pypi, pants master breaks as seen in https://travis-ci.org/pantsbuild/pants/builds/252126179.

Solution

Perform a version agnostic check.

Result

Improved test durability.

@kwlzn kwlzn requested review from jsirois and benjyw Jul 11, 2017

@kwlzn kwlzn merged commit cad4a70 into pantsbuild:master Jul 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood added this to the 1.3.1 milestone Jul 31, 2017

stuhood added a commit that referenced this pull request Jul 31, 2017

Improve transitive resolve package checking in tests. (#4738)
Problem

Currently, tests/python/pants_test/backend/python/tasks2/test_resolve_requirements.py::ResolveRequirementsTest::test_resolve_multiplatform_requirements performs a version-constrained check against an unpinned transitive dependency of CFFI. When new versions of this dep are released on pypi, pants master breaks as seen in https://travis-ci.org/pantsbuild/pants/builds/252126179.

Solution

Perform a version agnostic check.

Result

Improved test durability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment