New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fingerprint a bunch of go options #4743

Merged
merged 1 commit into from Jul 14, 2017

Conversation

Projects
None yet
2 participants
@stuhood
Copy link
Member

stuhood commented Jul 14, 2017

Problem

The --thrift-import option, which gets rendered into the generate go sources was not fingerprinted.

Solution

Fingerprint it and a few others, some of which should have immediate impact, and others which will only take effect once go has test caching.

Fingerprint a bunch of options: most importantly, the --thrift-import…
… option, which actually gets rendered into the generate go sources.

@stuhood stuhood requested review from benjyw and dturner-tw Jul 14, 2017

@benjyw

benjyw approved these changes Jul 14, 2017

Copy link
Contributor

benjyw left a comment

Makes me realize that fingerprint=True should have been the default...

@stuhood stuhood merged commit df55949 into pantsbuild:master Jul 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/go-fingerprints branch Jul 14, 2017

@stuhood stuhood added this to the 1.3.1 milestone Jul 14, 2017

stuhood added a commit to twitter/pants that referenced this pull request Jul 21, 2017

Fingerprint a bunch of go options. (pantsbuild#4743)
### Problem

The `--thrift-import` option, which gets rendered into the generate go sources was not fingerprinted.

### Solution

Fingerprint it and a few others, some of which should have immediate impact, and others which will only take effect once go has test caching.

stuhood added a commit that referenced this pull request Jul 31, 2017

Fingerprint a bunch of go options. (#4743)
### Problem

The `--thrift-import` option, which gets rendered into the generate go sources was not fingerprinted.

### Solution

Fingerprint it and a few others, some of which should have immediate impact, and others which will only take effect once go has test caching.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment