New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing content (copied from internal doc). #5015

Merged
merged 2 commits into from Nov 18, 2017

Conversation

Projects
None yet
3 participants
@thoward
Contributor

thoward commented Oct 25, 2017

Problem

This "common task" article was somehow created with a portion of the content cut off. This was just reported.

Solution

I referred to the internal version of the doc, and added the content here. Internal doc was in RST, so I converted to Markdown syntax.

@stuhood

This comment has been minimized.

Show comment
Hide comment
@stuhood

stuhood Oct 25, 2017

Member

Hm... @thoward : so, create_thrift_libraries is actually a Twitter-internal macro.

Member

stuhood commented Oct 25, 2017

Hm... @thoward : so, create_thrift_libraries is actually a Twitter-internal macro.

@thoward

This comment has been minimized.

Show comment
Hide comment
@thoward

thoward Nov 7, 2017

Contributor

Got it, so instead we should delete references to it from the OSS docs?

Contributor

thoward commented Nov 7, 2017

Got it, so instead we should delete references to it from the OSS docs?

@baroquebobcat

This comment has been minimized.

Show comment
Hide comment
@baroquebobcat

baroquebobcat Nov 7, 2017

Contributor

Makes sense to me.

Contributor

baroquebobcat commented Nov 7, 2017

Makes sense to me.

@thoward

This comment has been minimized.

Show comment
Hide comment
@thoward

thoward Nov 18, 2017

Contributor

Updated to remove reference to create_thrift_libraries.

Contributor

thoward commented Nov 18, 2017

Updated to remove reference to create_thrift_libraries.

@stuhood

Thanks!

@stuhood stuhood merged commit e13d486 into pantsbuild:master Nov 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@thoward thoward deleted the thoward:patch-1 branch Nov 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment