New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs_util directory cat-proto <fingerprint> #5065

Merged
merged 1 commit into from Nov 7, 2017

Conversation

Projects
None yet
2 participants
@illicitonion
Copy link
Contributor

illicitonion commented Nov 6, 2017

Gets the serialized bytes of a Directory proto

@illicitonion illicitonion requested a review from stuhood Nov 6, 2017

@illicitonion

This comment has been minimized.

Copy link
Contributor

illicitonion commented Nov 6, 2017

Depends on #5064

@stuhood

stuhood approved these changes Nov 6, 2017

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Nov 6, 2017

(I'm not super clear on where this will be used, since it would imply some other tool that is able to deserialize the proto?)

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/fs_util/cat-proto branch from 494d154 to 1a301a2 Nov 7, 2017

fs_util directory cat-proto <fingerprint>
Gets the serialized bytes of a Directory proto

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/fs_util/cat-proto branch from 1a301a2 to ea9ab51 Nov 7, 2017

@illicitonion illicitonion merged commit bcc16cc into pantsbuild:master Nov 7, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

illicitonion added a commit to twitter/pants that referenced this pull request Nov 7, 2017

Fix test compile
pantsbuild#5065 renamed the method

@illicitonion illicitonion referenced this pull request Nov 7, 2017

Merged

Fix test compile #5069

illicitonion added a commit that referenced this pull request Nov 7, 2017

Fix test compile (#5069)
#5065 renamed the method

@illicitonion illicitonion deleted the twitter:dwagnerhall/fs_util/cat-proto branch Nov 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment