New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a stable URL to restore kythe binary fetching #5137

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
2 participants
@stuhood
Copy link
Member

stuhood commented Nov 27, 2017

Problem

The repository URL we were using to fetch kythe was not stable, and a recent commit broke the old URLs.

Solution

Switch to fetching using a stable github URL.

Result

CI should be fixed.

@stuhood stuhood requested a review from benjyw Nov 27, 2017

@stuhood stuhood added this to the 1.3.1 milestone Nov 27, 2017

@kwlzn

kwlzn approved these changes Nov 27, 2017

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Nov 28, 2017

The relevant contrib shard passed: merging to fix master.

@stuhood stuhood merged commit 6924260 into pantsbuild:master Nov 28, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@stuhood stuhood deleted the twitter:stuhood/stabilize-kythe-binhost branch Nov 28, 2017

stuhood added a commit that referenced this pull request Nov 28, 2017

Use a particular git SHA to stabilize binary fetching. (#5137)
### Problem

The repository URL we were using to fetch kythe was not stable, and a recent commit broke the old URLs.

### Solution

Switch to fetching using a stable github URL.

### Result

CI should be fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment