New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wiki-related targets from contrib and back to docgen #5319

Merged
merged 7 commits into from Jan 17, 2018

Conversation

Projects
None yet
2 participants
@dotordogh
Copy link
Contributor

dotordogh commented Jan 13, 2018

Problem

There were some breakages once the confluence contrib plugin was fully registered and after doing some digging I realized that the markdown_to_html task uses the wiki-related targets that I tried moving into the plugin. Because something defined in a contrib plugin can't be used in pants source code, this caused the failing tests.

Solution

The solution is to remove the deprecation warnings from wiki-related targets in pants/backend/docgen and remove the (once copied) targets from the contrib plugin.

@stuhood
Copy link
Member

stuhood left a comment

Looks good, thanks.

The CI failure looks unrelated, so I'm going to merge.

@stuhood stuhood merged commit 7c92a6f into pantsbuild:master Jan 17, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@stuhood stuhood added this to the 1.4.x milestone Jan 17, 2018

stuhood added a commit that referenced this pull request Jan 17, 2018

Remove wiki-related targets from contrib and back to docgen (#5319)
There were some breakages once the confluence contrib plugin was fully registered and after doing some digging I realized that the markdown_to_html task uses the wiki-related targets that I tried moving into the plugin. Because something defined in a contrib plugin can't be used in pants source code, this caused the failing tests.

The solution is to remove the deprecation warnings from wiki-related targets in pants/backend/docgen and remove the (once copied) targets from the contrib plugin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment