New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the codeanalysis contrib plugin. #5322

Merged
merged 1 commit into from Jan 17, 2018

Conversation

Projects
None yet
3 participants
@benjyw
Copy link
Contributor

benjyw commented Jan 15, 2018

No description provided.

@benjyw

This comment has been minimized.

Copy link
Contributor

benjyw commented Jan 15, 2018

I'm not sure what needs to be done for a successful first-time publish. Is the PyPI package created automatically on first push? And how do we set the owners to match those on all the other packages?

@benjyw

This comment has been minimized.

Copy link
Contributor

benjyw commented Jan 15, 2018

In fact I'm not sure what needs to happen to get the CI to pass.

@benjyw benjyw requested review from jsirois and stuhood Jan 15, 2018

@wisechengyi

This comment has been minimized.

Copy link
Contributor

wisechengyi commented Jan 16, 2018

hmm I think it's due to timeout from @ensure_egine and @ensure_resolver,

@ensure_resolver
@ensure_engine
def run_shard(self, shard):
targets = self.targets_for_shard(shard)
pants_run = self.pants_test(targets + ['--jvm-platform-default-platform=java7',
'--gen-protoc-import-from-root'])
self.assert_success(pants_run)
def test_self(self):
self.assertEquals([t for s in range(0, self._SHARDS)
for t in self.targets_for_shard(s)],
self.targets)
. May need to further shard it out, or put them in a way so no single test is going to take more than 10 minutes.

On a good day, restarting the shard would do.

@stuhood
Copy link
Member

stuhood left a comment

@benjyw : The CI timeouts have been occurring periodically in master as well: need some more time spent on infrastructure soon.

But that does point to another question: are the tasks in the plugin enabled by default? If so, do you know how much total runtime they would add to compile and etc? It's possible that we should leave them enabled by default in terms of their options, but skip them in pantsbuild/pants/pants.ini to avoid paying the cost for them here.

@wisechengyi

This comment has been minimized.

Copy link
Contributor

wisechengyi commented Jan 17, 2018

(related note #5324 was merged)

@benjyw

This comment has been minimized.

Copy link
Contributor

benjyw commented Jan 17, 2018

The codeanalysis tasks are all installed in the 'index' goal, so I don't think they should have any impact at all on compile or any other goal.

@benjyw

This comment has been minimized.

Copy link
Contributor

benjyw commented Jan 17, 2018

Does anyone know what, if anything, needs to happen to create the new PyPI project for the first time?

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Jan 17, 2018

Nothing needs to happen: it will be created in the first release that pushes it. Afterward, the releaser will need to add all other pypi owners as owners of the package (as otherwise they would be the sole owner).

@benjyw benjyw merged commit 0a94094 into pantsbuild:master Jan 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:benjy/codeanalysis_pkg branch Jan 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment