New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the v1 engine option. #5338

Merged
merged 2 commits into from Jan 18, 2018

Conversation

Projects
None yet
3 participants
@stuhood
Copy link
Member

stuhood commented Jan 17, 2018

Problem

The v1 engine is on the way out, but we have not yet deprecated enabling it. Part of the reason for waiting is that we wanted the daemon to be in a usable state before requiring usage of v2: it now is.

Solution

Deprecate enabling the v1 engine. Will be cherry-picked to the 1.4.x branch.

@stuhood stuhood added this to the 1.4.x milestone Jan 17, 2018

@stuhood stuhood requested review from benjyw , mateor and kwlzn Jan 17, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Jan 17, 2018

Hold off on reviewing, if you wouldn't mind: I think this should also update the daemon docs.

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Jan 17, 2018

Ready for review: thanks!

@kwlzn

kwlzn approved these changes Jan 17, 2018

Copy link
Member

kwlzn left a comment

woot!

@benjyw

benjyw approved these changes Jan 17, 2018

Copy link
Contributor

benjyw left a comment

w00t!

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Jan 18, 2018

Only waiting on the OSX shard. Going to go ahead and merge.

@stuhood stuhood merged commit 278b7ab into pantsbuild:master Jan 18, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@stuhood stuhood deleted the twitter:stuhood/deprecate-v1-engine-option branch Jan 18, 2018

stuhood added a commit that referenced this pull request Jan 18, 2018

Deprecate the v1 engine option. (#5338)
### Problem

The v1 engine is on the way out, but we have not yet deprecated enabling it. Part of the reason for waiting is that we wanted the daemon to be in a usable state before requiring usage of v2: it now is.

### Solution

Deprecate enabling the v1 engine. Will be cherry-picked to the `1.4.x` branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment