New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable lighter contrib sanity checks #5340

Merged
merged 3 commits into from Jan 18, 2018

Conversation

Projects
None yet
2 participants
@stuhood
Copy link
Member

stuhood commented Jan 17, 2018

Problem

In short: #4992 skipped running the pkg_<name>_install_test function for contrib modules because some of those modules defined expensive checks, and because all contrib tests are run on dedicated Contrib shards already. But that, unfortunately, meant that we didn't even sanity check that contrib modules could be loaded as plugins.

Solution

Simplify all pkg_<name>_install_test functions to be simple checks that tasks are appropriately registered, and re-enable running them on the binary builder shard. Also, fix some registration issues that slipped through with the confluence module due to this gap.

Result

#5339 is fixed.

@stuhood stuhood requested review from jsirois and dotordogh Jan 17, 2018

@stuhood stuhood added this to the 1.4.x milestone Jan 17, 2018

@dotordogh
Copy link
Contributor

dotordogh left a comment

Looks great! Thank you for doing this!

@dotordogh

This comment has been minimized.

Copy link
Contributor

dotordogh commented Jan 18, 2018

After some reflection, I think it is worth updating the contrib/README.md to reflect that the install_test() should only be a sanity check that ensures the plugin is importable and how to actually check that.

@stuhood stuhood merged commit cb72c2a into pantsbuild:master Jan 18, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@stuhood stuhood deleted the twitter:stuhood/reenable-lighter-contrib-sanity-checks branch Jan 18, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Jan 18, 2018

(was waiting on the OSX shard overnight... oy)

stuhood added a commit that referenced this pull request Jan 18, 2018

Reenable lighter contrib sanity checks (#5340)
### Problem

In short: #4992 skipped running the `pkg_<name>_install_test` function for contrib modules because some of those modules defined expensive checks, and because all contrib tests are run on dedicated Contrib shards already. But that, unfortunately, meant that we didn't even sanity check that contrib modules could be loaded as plugins.

### Solution

Simplify all `pkg_<name>_install_test` functions to be simple checks that tasks are appropriately registered, and re-enable running them on the binary builder shard. Also, fix some registration issues that slipped through with the confluence module due to this gap.

### Result

#5339 is fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment