New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pantsd] Repair daemon wedge on log rotation. #5358

Merged
merged 2 commits into from Jan 19, 2018

Conversation

Projects
None yet
2 participants
@kwlzn
Copy link
Member

kwlzn commented Jan 19, 2018

Fixes #5354

@kwlzn kwlzn requested review from stuhood , jsirois and dotordogh Jan 19, 2018

@kwlzn kwlzn changed the title [pantsd] Repair daemon crash on log rotation. [pantsd] Repair daemon wedge on log rotation. Jan 19, 2018

@stuhood stuhood added this to the 1.4.x milestone Jan 19, 2018

@kwlzn

This comment has been minimized.

Copy link
Member

kwlzn commented Jan 19, 2018

@stuhood made a small change here to address the faulthandler + rotation case (s/RotatingFileHandler/FileHandler/) because afaict, this handler is only used in the case of the daemon and of --logdir. let me know if you're still 👍 with that.

@stuhood
Copy link
Member

stuhood left a comment

Yea, fine with me.

@stuhood stuhood merged commit c9105de into pantsbuild:master Jan 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

stuhood added a commit that referenced this pull request Jan 19, 2018

[pantsd] Repair daemon wedge on log rotation. (#5358)
Repair daemon crash on log rotation. Fixes #5354.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment