New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: do not resolve requirements if no python targets in targets' closure #5361

Merged
merged 1 commit into from Jan 20, 2018

Conversation

Projects
None yet
5 participants
@tdyas
Copy link
Contributor

tdyas commented Jan 19, 2018

Problem

If Python targets depend on resources targets, the resolve_requirements task will be invoked even if the current build does not have any Python targets in the targets to be processed. The resolve_requirements task should not do any work in that case.

Solution

Only resolve requirements if there are requirements actually needing resolution.

Result

Doesn't do the problematic work.

python2: do not resolve requirements if no python targets in targets …
…closure

If Python targets depend on resource targets, the resolve_requirements task
will be invoked even if the current build does not have any Python targets
in the targets to be processed. The resolve_requirements task should not do
any work in that case.
@kwlzn

kwlzn approved these changes Jan 20, 2018

@kwlzn kwlzn requested a review from benjyw Jan 20, 2018

@benjyw

benjyw approved these changes Jan 20, 2018

Copy link
Contributor

benjyw left a comment

Thanks for the fix!

@baroquebobcat
Copy link
Contributor

baroquebobcat left a comment

Thanks for this!

@stuhood stuhood merged commit 4d09a7c into pantsbuild:master Jan 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood added this to the 1.4.x milestone Jan 20, 2018

stuhood added a commit that referenced this pull request Jan 24, 2018

python2: do not resolve requirements if no python targets in targets …
…closure (#5361)

### Problem

If Python targets depend on `resources` targets, the resolve_requirements task will be invoked even if the current build does not have any Python targets in the targets to be processed. The resolve_requirements task should not do any work in that case.

### Solution

Only resolve requirements if there are requirements actually needing resolution.

### Result

Doesn't do the problematic work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment