New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure test report results are always exposed. #5368

Merged
merged 1 commit into from Jan 23, 2018

Conversation

Projects
None yet
2 participants
@jsirois
Copy link
Member

jsirois commented Jan 22, 2018

Previously test run failures would short-circuit exposing junit xml and
coverage reports to user-requested locations. A test now ensures
reports are always exposed to those locations.

Fixes #5323

@stuhood stuhood added this to the 1.4.x milestone Jan 22, 2018

@stuhood
Copy link
Member

stuhood left a comment

Thanks John!

Ensure test report results are always exposed.
Previously test run failures would short-circuit exposing junit xml and
coverage reports to user-requested locations. A test now ensures
reports are always exposed to those locations.

Fixes #5323

@jsirois jsirois force-pushed the jsirois:issues/5323 branch from 8eb9a36 to 9c265ef Jan 22, 2018

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Jan 23, 2018

Still no assigned OSX shard :/ I'm going to land this as-is.

@jsirois jsirois merged commit c36c2ee into pantsbuild:master Jan 23, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@jsirois jsirois deleted the jsirois:issues/5323 branch Jan 23, 2018

stuhood added a commit that referenced this pull request Jan 24, 2018

Ensure test report results are always exposed. (#5368)
Previously test run failures would short-circuit exposing junit xml and
coverage reports to user-requested locations. A test now ensures
reports are always exposed to those locations.

Fixes #5323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment