New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not downloading node package multiple times #5372

Merged
merged 1 commit into from Jan 23, 2018

Conversation

Projects
None yet
3 participants
@UnrememberMe
Copy link
Contributor

UnrememberMe commented Jan 22, 2018

Problem

With PR 5248, we are downloading node.js package multiple times because the package directory is overwritten.

Solution

Move the output directory to be sibling, instead of parent, of the downloaded tgz file.

Result

Only download node.js once.

@stuhood stuhood requested a review from benjyw Jan 22, 2018

@stuhood stuhood added this to the 1.4.x milestone Jan 22, 2018

@benjyw

benjyw approved these changes Jan 22, 2018

Copy link
Contributor

benjyw left a comment

Thanks for the fix!

@stuhood stuhood merged commit d1d0871 into pantsbuild:master Jan 23, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

stuhood added a commit that referenced this pull request Jan 24, 2018

Do not download node package multiple times (#5372)
### Problem

With PR 5248, we are downloading node.js package multiple times because the package directory is overwritten.

### Solution

Move the output directory to be a sibling, instead of parent, of the downloaded tgz file.

### Result

Only download node.js once.
@benjyw
Copy link
Contributor

benjyw left a comment

Am I right in thinking that this will still unpack the tarball every time?

@UnrememberMe UnrememberMe deleted the UnrememberMe:UnrememberMe/node_tarball_extract_fix branch Mar 27, 2018

@UnrememberMe UnrememberMe restored the UnrememberMe:UnrememberMe/node_tarball_extract_fix branch Mar 27, 2018

@UnrememberMe UnrememberMe deleted the UnrememberMe:UnrememberMe/node_tarball_extract_fix branch Apr 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment