Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Repoint the 'current' symlink even for valid VTs. #5375
Previously we only repointed it for invalid ones, which meant
This change also renames results_dir_path() to _results_dir_path(),
It also removes a superfluous arg to a test helper method, fixes
left a comment
I was surprised to see that the
I have no objection, but I am also not sure that I follow the motivating case. It seems like the
If I hit this case personally, I would wonder if I found a hole in the target's fingerprinting strategy. But I am willing to trust you are onto something.
The test proves that something is up (I verified that it failed without the change)...
The specific case I had was when going back and forth between two different values of a fingerprinted option. The option fingerprint affects the cache_key.id, apparently, so the