New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pantsd] Repair pantsd integration tests for execution via pantsd. #5387

Merged
merged 2 commits into from Jan 25, 2018

Conversation

Projects
None yet
2 participants
@kwlzn
Copy link
Member

kwlzn commented Jan 25, 2018

Fixes #5056

@kwlzn kwlzn force-pushed the twitter:kwlzn/pantsd_inception branch from 84f6c66 to a3ca901 Jan 25, 2018

@kwlzn kwlzn requested review from stuhood and dotordogh Jan 25, 2018

@stuhood
Copy link
Member

stuhood left a comment

Thanks!



def _matching_process_set(name):
return {p for p in _safe_iter_matching_processes(name)}

This comment has been minimized.

@stuhood

stuhood Jan 25, 2018

Member

set(_safe_iter_matching_processes(name))? Might make the helper method unnecessary...

@kwlzn kwlzn force-pushed the twitter:kwlzn/pantsd_inception branch from 67d6f7b to d7eb69d Jan 25, 2018

@kwlzn kwlzn force-pushed the twitter:kwlzn/pantsd_inception branch from d7eb69d to 230b12a Jan 25, 2018

@kwlzn kwlzn merged commit ac5ad20 into pantsbuild:master Jan 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment