New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pantsd] Don't invalidate on surface name changes to config/rc files. #5408

Merged
merged 2 commits into from Jan 30, 2018

Conversation

Projects
None yet
2 participants
@kwlzn
Copy link
Member

kwlzn commented Jan 30, 2018

Fixes #5280

@kwlzn kwlzn requested review from stuhood and benjyw Jan 30, 2018

@@ -145,7 +145,7 @@ def register_bootstrap_options(cls, register):

# These logging options are registered in the bootstrap phase so that plugins can log during
# registration and not so that their values can be interpolated in configs.
register('-d', '--logdir', advanced=True, metavar='<dir>',
register('-d', '--logdir', advanced=True, metavar='<dir>', daemon=False,

This comment has been minimized.

@stuhood

stuhood Jan 30, 2018

Member

I've never seen this one configured on the CLI, so it feels like it would be fine to continue to include it in the fingerprint.

This comment has been minimized.

@kwlzn

kwlzn Jan 30, 2018

Member

k, it didn't seem relevant to the daemon to me since it's only used for logging run output - but, restored.

@stuhood stuhood added this to the 1.4.x milestone Jan 30, 2018

@kwlzn kwlzn merged commit 0efaef2 into pantsbuild:master Jan 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

stuhood added a commit that referenced this pull request Feb 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment