New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get version from version file not by running pants #5428

Merged
merged 1 commit into from Feb 3, 2018

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

illicitonion commented Feb 3, 2018

This avoids needing to compile the whole rust engine and stuff, when
just bundling up a pex.

Get version from version file not by running pants
This avoids needing to compile the whole rust engine and stuff, when
just bundling up a pex.

@illicitonion illicitonion requested a review from stuhood Feb 3, 2018

@stuhood

stuhood approved these changes Feb 3, 2018

@kwlzn

kwlzn approved these changes Feb 3, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Feb 3, 2018

Travis is acting a bit strangely, and refusing to let me restart a shard. But I have high confidence that it is unrelated, so I will merge this.

@stuhood stuhood added this to the 1.4.x milestone Feb 3, 2018

@stuhood stuhood merged commit c9feaa8 into pantsbuild:master Feb 3, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

stuhood added a commit that referenced this pull request Feb 23, 2018

Get version from version file not by running pants (#5428)
This avoids needing to compile the whole rust engine and stuff, when just bundling up a pex.

@illicitonion illicitonion deleted the twitter:dwagnerhall/versionfromfile branch Feb 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment