New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate IDE project generation tasks. #5432

Merged
merged 1 commit into from Feb 4, 2018

Conversation

Projects
None yet
2 participants
@benjyw
Copy link
Contributor

benjyw commented Feb 3, 2018

They aren't used or updated, yet they impose a significant
maintenance burden because they have tentacles into so many
parts of the codebase.

Also removes all their integration tests, as those are very heavy,
and not worth the trouble for code that is about to be deleted.

Deprecate IDE project generation tasks.
They aren't used or updated, yet they impose a significant
maintenance burden because they have tentacles into so many
parts of the codebase.

Also removes all their integration tests, as those are very heavy,
and not worth the trouble for code that is about to be deleted.

@benjyw benjyw requested review from wisechengyi and stuhood Feb 3, 2018

@@ -35,6 +36,11 @@
from pants.util.dirutil import safe_mkdir, safe_walk


deprecated_module('1.7.0.dev0',

This comment has been minimized.

@wisechengyi

wisechengyi Feb 4, 2018

Contributor

Does it mean class EnsimeGen(IdeGen) is auto deprecated as well?

This comment has been minimized.

@benjyw

benjyw Feb 4, 2018

Contributor

Yes, any subclass must import ide_gen.py, which triggers the deprecation warning.

@benjyw

This comment has been minimized.

Copy link
Contributor

benjyw commented Feb 4, 2018

BTW These tasks aren't marked public, so we could also just kill them outright. Thoughts?

@wisechengyi

This comment has been minimized.

Copy link
Contributor

wisechengyi commented Feb 4, 2018

It's always safe to deprecate first. We (twitter) don't have any issue deleting it, but this might be worth an email to pants-devel@ if you want to do it now.

@benjyw benjyw merged commit de2add4 into pantsbuild:master Feb 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:deprecate_ide_gen branch Feb 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment