New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove support dir overrides #5489

Merged
merged 1 commit into from Feb 21, 2018

Conversation

Projects
None yet
3 participants
@cosmicexplorer
Copy link
Contributor

cosmicexplorer commented Feb 20, 2018

Problem/Solution

@benjyw and I left in some manual get_support_dir() overrides for the buildozer and protoc subsystems subclassing BinaryTool in #5471. The paths have since been copied over in s3 so that these overrides can be removed.

Result

./pants test contrib/buildrefactor/tests/python/pants_test/contrib/buildrefactor:: tests/python/pants_test/backend/codegen/protobuf/java:: succeeded locally.

@stuhood stuhood requested a review from benjyw Feb 20, 2018

@benjyw

benjyw approved these changes Feb 21, 2018

@stuhood stuhood merged commit de972ec into pantsbuild:master Feb 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment