Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[pantsd] Set the remote environment for pantsd-runner and child processes. #5508
Currently, env vars set in post-pantsd-launching runs that use the daemon fail to inherit env vars correctly in child processes of pantsd-runners. Anything that relies on this will be broken with the daemon enabled for
Additionally, env vars that are set during the pantsd-launching run will currently leak stale env state into child processes of pantsd-runners.
Set the remote environment as the local environment for
left a comment
Approving because it preserves backwards compatibility, but I think long term this is the wrong direction to go. I would much prefer that everything which could invalidate caches be forced to be flags to pants in some way, rather than passing env around verbatim.